[gpfdist] Use event_base with libevent 2.0+ to avoid thread-unsafe event_init #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfphoenix78
reviewed
Jul 17, 2025
|
Good start. Do we plan to enable multi-threads for libevent 2.0+ in current PR? |
No, simple multi threads mvp show performance downgrade. |
yjhjstz
force-pushed
the
opt_events
branch
2 times, most recently
from
056bfc3 to
b756915
Compare
So do we still need the PR? |
yes, using thread-safe APIs is a better choice. In case we found the right way. |
…n gpfdist The legacy event_init() function is not thread-safe and can cause issues when gpfdist is run in multi-threaded environments. This patch updates gpfdist to use libevent 2.0+'s thread-safe APIs, specifically `event_base` along with `event_assign()` and `evtimer_assign()`. A new global `gcb.event_base` is introduced and used when compiled with libevent ≥ 2.0.1. This avoids the need for the deprecated and non-thread-safe `event_set()` / `evtimer_set()` APIs, and prepares gpfdist for better thread safety.
gfphoenix78
reviewed
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy event_init() function is not thread-safe and can cause issues when gpfdist is run in multi-threaded environments. This patch updates gpfdist to use libevent 2.0+'s thread-safe APIs, specifically
event_basealong withevent_assign()andevtimer_assign().A new global
gcb.event_baseis introduced and used when compiled with libevent ≥ 2.0.1. This avoids the need for the deprecated and non-thread-safeevent_set()/evtimer_set()APIs, and prepares gpfdist for better thread safety.This change maintains backward compatibility with older libevent versions via conditional compilation.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions