Skip to content

server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 4.20
Choose a base branch
from
Open

server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset #11228

wants to merge 4 commits into from
+17 −0

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #11159

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (0f0155c) to head (807dd9a).
⚠️ Report is 44 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../cloudstack/user/UserPasswordResetManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11228   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13283    13284    +1     
=========================================
  Files          5656     5656           
  Lines        497996   498002    +6     
  Branches      60401    60401           
=========================================
+ Hits          80533    80534    +1     
- Misses       408500   408506    +6     
+ Partials       8963     8962    -1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.02% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

much more needed on this @weizhouapache ?

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Member Author

much more needed on this @weizhouapache ?

@DaanHoogland
that's all, I think

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14228

@DaanHoogland
Copy link
Contributor

@blueorangutan test keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14231

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14234

@blueorangutan
Copy link

[SF] Trillian test result (tid-13810)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11228-t13810-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Member Author

@DaanHoogland
I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 18, 2025 •
edited
Loading

@DaanHoogland I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

still looks good. ;) still needs testing though. ...

@weizhouapache weizhouapache marked this pull request as ready for review August 5, 2025 03:15
@harikrishna-patnala
Copy link
Contributor

@weizhouapache also please check if this PR needs any branch or milestone changes

@weizhouapache weizhouapache changed the base branch from main to 4.20 August 29, 2025 08:34
@weizhouapache
Copy link
Member Author

thanks @harikrishna-patnala
changed the target branch to 4.20

@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Aug 29, 2025
sureshanaparti
sureshanaparti approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

vishesh92
vishesh92 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache weizhouapache changed the title server: add user.password.reset.smtp.useStartTLS for password reset server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset Sep 12, 2025
@vishesh92
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15275

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-14518)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees
No one assigned
Labels
status:needs-testing
Projects
None yet
Milestone
4.20.2
Development

Successfully merging this pull request may close these issues.

CS 4.20.1 Password Reset Functionality Java Error
6 participants
@weizhouapache @DaanHoogland @blueorangutan @harikrishna-patnala @vishesh92 @sureshanaparti