Skip to content

Prevent multi-select dropdown menu from floating on scrolling through the form #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes #11217

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Screencast.from.2025-07-17.12.04.06.PM.webm

How did you try to break this feature and the system with this change?

@Pearl1594
Copy link
Contributor Author

@rosi-shapeblue Can you please review if this fixes the issue. Thanks.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.18%. Comparing base (714b04e) to head (1215190).

Additional details and impacted files
@@             Coverage Diff              @@
##              4.19   #11237       +/-   ##
============================================
+ Coverage     4.28%   15.18%   +10.89%     
- Complexity       0    11365    +11365     
============================================
  Files          372     5415     +5043     
  Lines        29746   475901   +446155     
  Branches      5230    58097    +52867     
============================================
+ Hits          1274    72252    +70978     
- Misses       28327   395564   +367237     
- Partials       145     8085     +7940     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 changed the base branch from 4.20 to 4.19 July 17, 2025 16:16
@Pearl1594 Pearl1594 changed the base branch from 4.19 to 4.20 July 17, 2025 16:17
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@Pearl1594 Pearl1594 changed the base branch from 4.20 to 4.19 July 17, 2025 16:26
@Pearl1594 Pearl1594 closed this Jul 17, 2025
@Pearl1594 Pearl1594 reopened this Jul 17, 2025
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11237 (QA-JID-672)

@DaanHoogland
Copy link
Contributor

@Pearl1594 , I could not fine domain on the add compute offering modal, but then
Screenshot 2025-07-18 at 10 59 51

so I think there are more to do

@Pearl1594
Copy link
Contributor Author

@Pearl1594 , I could not fine domain on the add compute offering modal, but then Screenshot 2025-07-18 at 10 59 51

so I think there are more to do

Thanks Daan. I've addressed it at other places.
Regarding domain dropdown menu - that is visible when public field is unchecked.

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11237 (QA-JID-673)

Copy link

@DaanHoogland
Copy link
Contributor

looks great @Pearl1594 and I think we can merge as is, but I also found some select fields in the add backup offering that do not move with the parent when scrolling.
(sorry for my diligence)
I think a search for a-select on teh whole ui project makes sense. I wonder why this behavior is not default in ant3d.

@sureshanaparti sureshanaparti requested a review from vishesh92 July 20, 2025 15:37
@sureshanaparti sureshanaparti added this to the 4.19.4 milestone Jul 21, 2025
@shwstppr
Copy link
Contributor

@Pearl1594 I think this will be needed across UI if we want consistent behaviour. Maybe we need to create a new custom select component which enforces this behaviour. For starters, if we want to change it in just the offering forms, that is fine too.

@DaanHoogland
Copy link
Contributor

I agree @shwstppr , merging this is a good start but enforcing behaviour with a systemwide component makes sense.

@Pearl1594
Copy link
Contributor Author

I agree as well. I think that's a better way to move ahead. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants