Skip to content

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #7763

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.57%. Comparing base (06c80cd) to head (d848235).
⚠️ Report is 25 commits behind head on 4.19.

Files with missing lines Patch % Lines
...m/cloud/network/security/SecurityGroupVMMapVO.java 0.00% 3 Missing ⚠️
...oud/network/security/SecurityGroupManagerImpl.java 0.00% 3 Missing ⚠️
...ud/network/security/SecurityGroupManagerImpl2.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #11243      +/-   ##
============================================
+ Coverage     15.18%   16.57%   +1.39%     
- Complexity    11364    14058    +2694     
============================================
  Files          5415     5772     +357     
  Lines        475888   512945   +37057     
  Branches      58094    62306    +4212     
============================================
+ Hits          72256    85026   +12770     
- Misses       395546   418438   +22892     
- Partials       8086     9481    +1395     
Flag Coverage Δ
uitests 3.89% <ø> (-0.39%) ⬇️
unittests 17.47% <0.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14253

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13819)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11243-t13819-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@sudo87
Copy link
Collaborator

sudo87 commented Aug 28, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14748

@weizhouapache weizhouapache marked this pull request as ready for review August 28, 2025 08:30
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sudo87
Copy link
Collaborator

sudo87 commented Aug 29, 2025

lgtm tested the ipv6 between 2 vms with the fix

@DaanHoogland DaanHoogland merged commit ba7ec88 into apache:4.19 Aug 29, 2025
23 of 44 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-sg-rule-ipv6 branch August 29, 2025 09:39
@weizhouapache weizhouapache added this to the 4.19.4 milestone Aug 29, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account level ingress rules do not work with ipv6
6 participants