CKS: update cloud.kubernetes.cluster.network.offering to dynamic #11847
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11847 +/- ##
============================================
- Coverage 16.19% 16.18% -0.01%
+ Complexity 13306 13302 -4
============================================
Files 5657 5657
Lines 498467 498467
Branches 60491 60491
============================================
- Hits 80702 80669 -33
- Misses 408783 408823 +40
+ Partials 8982 8975 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shwstppr
approved these changes
Nov 3, 2025
Contributor
|
anymore testing or discussions needed on this @weizhouapache ? |
Member
Author
I think no. marked as |
Contributor
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15633 |
kiranchavala
approved these changes
Nov 5, 2025
Contributor
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
Tested manually
Changed the global setting "cloud.kubernetes.cluster.network.offering" to a new value and created a cks cluster .
The cks cluster created a network with the specified offering
2025-11-05 10:27:37,911 DEBUG [c.c.a.ApiServlet] (qtp253011924-21:[ctx-49129e7f]) (logid:7c626044) ===START=== 10.0.3.251 -- GET name=cloud.kubernetes.cluster.network.offering&value=test-cks-networkoffering&command=updateConfiguration&response=json&sessionkey=tb7YtPglMmm31eyggpz2VG1Pkks
2025-11-05 10:27:37,911 DEBUG [c.c.a.ApiServlet] (qtp253011924-21:[ctx-49129e7f]) (logid:7c626044) Two factor authentication is already verified for the user 2, so skipping
2025-11-05 10:27:37,913 DEBUG [c.c.a.ApiServer] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"1d2e5598-ba13-11f0-b11b-1e002f00043c"}]' is allowed to perform API calls: 0.0.0.0/0,::/0
2025-11-05 10:27:37,914 INFO [o.a.c.a.DynamicRoleBasedAPIAccessChecker] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) Account for user id 1d2fa88c-ba13-11f0-b11b-1e002f00043c is Root Admin or Domain Admin, all APIs are allowed.
2025-11-05 10:27:37,914 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2025-11-05 10:27:37,914 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) API rate limiting is disabled. We will not use ApiRateLimitService.
2025-11-05 10:27:37,916 WARN [c.c.c.ConfigurationManagerImpl] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) Did not find configuration [cloud.kubernetes.cluster.network.offering] in Config.java. Perhaps moved to ConfigDepot.
2025-11-05 10:27:37,916 WARN [c.c.c.ConfigurationManagerImpl] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) Did not find configuration [cloud.kubernetes.cluster.network.offering] in Config.java. Perhaps moved to ConfigDepot.
2025-11-05 10:27:37,916 DEBUG [c.c.c.ConfigurationManagerImpl] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) Not proceeding with configuration [cloud.kubernetes.cluster.network.offering]'s range validation, as it uses ConfigKey instead of Config.
2025-11-05 10:27:37,929 WARN [c.c.c.ConfigurationManagerImpl] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) Did not find configuration [cloud.kubernetes.cluster.network.offering] in Config.java. Perhaps moved to ConfigDepot.
2025-11-05 10:27:37,929 DEBUG [c.c.a.ApiServlet] (qtp253011924-21:[ctx-49129e7f, ctx-314a9d25]) (logid:7c626044) ===END=== 10.0.3.251 -- GET name=cloud.kubernetes.cluster.network.offering&value=test-cks-networkoffering&command=updateConfiguration&response=json&sessionkey=tb7YtPglMmm31eyggpz2VG1Pkks
DaanHoogland
deleted the
4.20-dynamic-cloud.kubernetes.cluster.network.offering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates global setting cloud.kubernetes.cluster.network.offering to dynamic so that restartin mgmt server is not required.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?