KVM memballooning requires free page reporting and autodeflate #11932
Conversation
| StringBuilder memBalloonBuilder = new StringBuilder(); | ||
| memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n"); | ||
| memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'"); | ||
| if (memBalloonModel != MemBalloonModel.NONE) { |
There was a problem hiding this comment.
add libvirt version check ?
There was a problem hiding this comment.
I was thinking it doesn't look necessary. This was introduced in v6.9.0. I checked both the oldest non-EOL enterprise distros and they all have newer versions:
- ubuntu 22.04 LTS: 8.0.0 https://launchpad.net/ubuntu/jammy/+source/libvirt
- CentOS/AlmaLinux/RockyLinux 9: 10.10.0 https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/l/libvirt-10.10.0-7.7.el9_6.x86_64.rpm
even EOL versions like CentOS 8 had v 8.0.0...
There was a problem hiding this comment.
ok, good enough.
have you checked the qemu version ?
There was a problem hiding this comment.
This was added in qemu 5.1 and requires host kernel 5.7.
ubuntu 22.04 is qemu 6.2: https://launchpad.net/ubuntu/jammy/+source/qemu
rocky linux 9 is qemu 9.1: https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/q/qemu-kvm-9.1.0-15.el9_6.9.x86_64.rpm
So no problems there either.
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11932 +/- ##
============================================
+ Coverage 17.36% 17.56% +0.20%
- Complexity 15245 15543 +298
============================================
Files 5888 5909 +21
Lines 525831 529061 +3230
Branches 64183 64618 +435
============================================
+ Hits 91298 92946 +1648
- Misses 424227 425661 +1434
- Partials 10306 10454 +148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pretty sure the simulator failure is unrelated to my changes |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15585 |
4 participants
Description
As per #11930 KVM's memory ballooning does not auto-inflate and auto-deflate without the Free Page Reporting and autodeflate attributes on the memballoon configuration.
This is a change similar to OpenStack's NOVA:
openstack/nova@cd401c5
Basically if memballooning is enabled for KVM, these features are also always enabled. Having memory ballooning on in cloudstack otherwise does nothing as there is no tooling to inflate or deflate the balloon.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Not yet tested, hoping CI/CD runs through some self-tests, then I'll try a test deployment.
How did you try to break this feature and the system with this change?
N/A