Fix RESTRICTED_TOKENS typo: " javax" (leading space) fails to prevent javax binding#12709
Open
robinkarlberg wants to merge 1 commit intoapache:mainfrom
Open
Fix RESTRICTED_TOKENS typo: " javax" (leading space) fails to prevent javax binding#12709robinkarlberg wants to merge 1 commit intoapache:mainfrom
robinkarlberg wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RESTRICTED_TOKENSis used to blacklist tokens for the JavaScript engine, used for rules etc. However, I saw that one of the entries" javax"has an accidental space in it, it should most likely be"javax".As far as I understand, the typo does not lead to any security impact as the
--no-javaflag disablesjavaxaccess, so that's why I'm creating an issue here on GitHub, and not a vulnerability disclosure. Consider this more of a little cleanup of the code.Types of changes
How Has This Been Tested?
Test still pass.