Skip to content

feat(ios): image + video quality, disable saving to camera roll/photo album, image scaling #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(ios): image + video quality, disable saving to camera roll/photo album, image scaling #46

wants to merge 6 commits into from

Conversation

@abilio-henrique
Copy link

  • Added image and video quality options for iOS
  • Added option to disable saving photos to camera roll/photo album
  • Added image scaling options

radev
radev reviewed Oct 27, 2015
View reviewed changes
src/ios/CDVCapture.m
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be zero here.

mikkelsjolin added a commit to mikkelsjolin/cordova-plugin-media-capture that referenced this pull request Feb 1, 2017
@mikkelsjolin
Implement iOS fixes from PR apache#46
dad936d
mikkelsjolin added a commit to mikkelsjolin/cordova-plugin-media-capture that referenced this pull request Feb 1, 2017
@mikkelsjolin
Implement iOS fixes from PR apache#46
556090a
@diogeneshamilton
Copy link

Is this ever getting merged? My project specifically needs to be able to set whether the photo is saved to the photo album, and this PR seems good to go.

@janpio janpio changed the title Additions for iOS feat(ios): image + video quality, disable saving to camera roll/photo album, image scaling Jul 4, 2019
janpio
janpio requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard conflict (unsurprisingly after so long), but the changes look interesting and good - so it might be worth to create new PRs based on master that add the individual features one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janpio janpio janpio requested changes

Assignees

No one assigned

Labels

enhancement platform: ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abilio-henrique @diogeneshamilton @radev @janpio @andrew-garside-rfg