check for required permission before video capture #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@stevengill, @agrieve, @shazron could you please review this PR, the code is added to support Android 8 permissions as the flow is changed. |
|
I think this can be closed as it has been fixed elsewhere. |
Member
|
Do you have a link handy? |
|
#95? |
Member
|
This PR here seems to have quite some more code and differentiates between different permissions being required. Might that be relevant? |
|
@janpio yeah sounds great. What are the next steps? |
Author
5 tasks
Author
|
Nope. I ended up switching to React Native. It's a shame that this project is more or less dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist