(android) Don't overwrite the whole SystemUiVisibility in setStatusBarTransparent - #276
Open
mohammadrafigh wants to merge 1 commit into
Open
(android) Don't overwrite the whole SystemUiVisibility in setStatusBarTransparent#276mohammadrafigh wants to merge 1 commit into
mohammadrafigh wants to merge 1 commit into
Conversation
boedy
added a commit
to boedy/cordova-plugin-statusbar
that referenced
this pull request
Apr 2, 2026
OR with existing flags instead of overwriting them, so other plugins' flags (e.g. navigation bar hiding) are not clobbered. See: apache#276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275
Platforms affected
Android
Motivation and Context
in
setStatusBarTransparentfunction, current SystemUiVisibility is being replaced by the new one, which is incorrect as stated in #275.Description
Like other places in the same codebase, I just called
getSystemUiVisibilitybefore applying the new flags and used current visibility as a base option for those flags.Testing
It's already mentioned in #275.
Checklist
(platform)if this change only applies to one platform (e.g.(android))