Skip to content

Conversation

Nashuim
Copy link

@Nashuim Nashuim commented Dec 10, 2024

Platforms affected

iOS

Motivation and Context

Fixes #243

Description

Frame y origin would be incorrect on iOS phones with floating islands when the statusbar isn't overlaying the web view. This change changes the origin so that it takes the webview's safeAreaTop into account

Testing

Tested on iOS 17 and iOS 18 on iPhone 14 and simulators

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPhone 14 Pro floating island status bar height incorrect

1 participant