branch-4.0: [fix](compaction) Keep cumulative inputs mergeable after score trimming #65470 - #67602
Open
Yukang-Lian wants to merge 1 commit into
Open
Conversation
…ng (apache#65470) Issue Number: None Related PR: apache#59268 Problem Summary: When the cumulative compaction max score is reduced, back trimming can leave a single non-overlapping rowset. It cannot be compacted alone, so compaction repeatedly returns `CUMULATIVE_NO_SUITABLE_VERSION` without advancing the cumulative point. This change remembers the last trimmed rowset in both cloud and local size-based policies. If trimming strands a single non-overlapping rowset, it restores the direct successor and allows one max-score overshoot so the input remains mergeable. Existing overlapping-singleton and cloud empty-rowset behavior is unchanged. Prevent max-score trimming from leaving an unmergeable cumulative compaction input. (cherry picked from commit 54300f9)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #65470, #59268
Problem Summary: Backport #65470 to
branch-4.0. Max-score tail trimming can otherwise leave a single non-overlapping cumulative rowset, which cannot be compacted alone and repeatedly returns no suitable version.The cloud and local policies remember the last trimmed rowset and restore that direct successor when trimming would strand a non-overlapping singleton. A one-off max-score overshoot is accepted so the input remains mergeable. The test-context conflict was resolved against this branch's
olaplayout by retaining existing branch tests and adding only #65470's focused regression cases.Source commit:
54300f922fddbeac6e679a83d7829444d4a72f77. The branch is based on the latestbranch-4.0at publication time.Release note
Prevent max-score trimming from leaving an unmergeable cumulative-compaction input on branch-4.0.
Check List (For Author)
git diff --check: passed