[improvement](fe) Make max_user_connections upper bound follow qe_max_connection - #67622
Open
HonestManXin wants to merge 1 commit into
Open
[improvement](fe) Make max_user_connections upper bound follow qe_max_connection#67622HonestManXin wants to merge 1 commit into
HonestManXin wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: Selected model is at capacity. Please try a different model. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the per-user connection limit
max_user_connectionswas hard-coded to a maximum of 10000. When operators raised the FE global connection limitqe_max_connectionabove 10000, a single user could not be granted more than 10000 connections, which is unreasonable since the effective limit is already bounded by the global setting.Now the upper bound of
max_user_connectionsisMath.max(qe_max_connection,10000), so a user can be configured up to the global limit while still keeping the original 10000 floor for backward compatibility.