[FLINK-37630] Support flink cdc pipeline Yarn session mode #3989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyCurry30
reviewed
Apr 16, 2025
.../main/java/org/apache/flink/cdc/composer/flink/deployment/YarnSessionDeploymentExecutor.java
Outdated
Show resolved
Hide resolved
|
Thank you for your contribution. Could you please add the doc for this mode? |
|
As discuss with @lvyanquan ：
|
MOBIN-F
reviewed
May 20, 2025
Comment on lines
+96
to
+99
| // If applicationId is passed, we get the state of yarn; if not, we create a session | ||
| // cluster. | ||
| String applicationId = flinkConfig.get(YarnConfigOptions.APPLICATION_ID); | ||
| if (applicationId != null) { |
There was a problem hiding this comment.
It seems that we cannot determine whether the application_id does not exist or is a misspelled application_id. If it is a misspelled, a new session cluster will be generated each time it is provided
There was a problem hiding this comment.
Maybe we can add a simple validate method.
joyCurry30
reviewed
May 20, 2025
...src/main/java/org/apache/flink/cdc/composer/flink/deployment/AbstractDeploymentExecutor.java
Outdated
Show resolved
Hide resolved
Comment on lines
+67
to
+70
| if (flinkConfig.get(PipelineOptions.JARS) == null) { | ||
| flinkConfig.set( | ||
| PipelineOptions.JARS, Collections.singletonList(getFlinkCDCDistJarFromEnv())); | ||
| } |
There was a problem hiding this comment.
If "JARS" not null, do we need to add the flink cdc dist into JARS?
There was a problem hiding this comment.
As application mode it seem this.
.../main/java/org/apache/flink/cdc/composer/flink/deployment/YarnSessionDeploymentExecutor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/flink/cdc/composer/flink/deployment/YarnSessionDeploymentExecutor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support flink cdc pipeline Yarn session mode