[FLINK-37096][cdc-connect] fix The purpose of the issue is to change the value of the delay curve from 20098d to -1ms in the full phase. #4034
+277
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiqian
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Thanks for @Sukang1002's update!
Kindly reminder: mvn verify -DskipTests could be executed locally to spot any code style violations in advance.
There was a problem hiding this comment.
Add license headers for newly committed files, and could be renamed to MongoDBMetricsITCase
Comment on lines
+61
to
+62
| @RunWith(Parameterized.class) | ||
| public class MongoDBMetricCase { |
There was a problem hiding this comment.
Please write test cases based on JUnit 5 and AssertJ.
Comment on lines
+67
to
+70
| this.mongoContainer = | ||
| new MongoDBContainer("mongo:" + mongoVersion) | ||
| .withSharding() | ||
| .withLogConsumer(new Slf4jLogConsumer(LOG)); |
There was a problem hiding this comment.
Consider extending MongoDBSourceTestBase instead of constructing containers manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc:FLINK-37096