Skip to content

[FLINK-38641][cdc/mysql] Unquote double quotes from default values on MySQL #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

[FLINK-38641][cdc/mysql] Unquote double quotes from default values on MySQL #4171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../src/main/java/io/debezium/connector/mysql/antlr/listener/DefaultValueParserListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ public void exitDefaultValue(boolean skipIfUnknownOptional) {
}

private String unquote(String stringLiteral) {
if (stringLiteral != null && stringLiteral.startsWith("'") && stringLiteral.endsWith("'")) {
if (stringLiteral != null
&& ((stringLiteral.startsWith("'") && stringLiteral.endsWith("'"))
|| (stringLiteral.startsWith("\"") && stringLiteral.endsWith("\"")))) {
return stringLiteral.substring(1, stringLiteral.length() - 1);
}
return stringLiteral;
Expand Down
2 changes: 1 addition & 1 deletion ...l-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/table/MySqlConnectorITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1514,7 +1514,7 @@ void testDdlWithDefaultStringValue() throws Exception {
+ " double_c DOUBLE DEFAULT ' 25',\n"
+ " double_un_c DOUBLE UNSIGNED DEFAULT ' 26',\n"
+ " double_un_z_c DOUBLE UNSIGNED ZEROFILL DEFAULT ' 27',\n"
+ " tiny_un_c TINYINT UNSIGNED DEFAULT ' 28 '"
+ " tiny_un_c TINYINT UNSIGNED DEFAULT \" 28 \""
+ " );");
}
actualRows.addAll(fetchRows(iterator, expected.length - 2));
Expand Down