Skip to content

[FLINK-37831] V3.1 do not retry failed index operations #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.1
Choose a base branch
from
Open

[FLINK-37831] V3.1 do not retry failed index operations #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...rc/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,14 @@ private void handleFailedRequest(
List<Operation> requestEntries,
Consumer<List<Operation>> requestResult,
Throwable error) {
LOG.warn(
"The BulkRequest of {} operation(s) has failed due to: {}",
requestEntries.size(),
error.getMessage());
LOG.debug("The BulkRequest has failed", error);
LOG.debug("The BulkRequest has failed. Error: {}", error);
numRecordsOutErrorsCounter.inc(requestEntries.size());

if (isRetryable(error.getCause())) {
if (isRetryable(error.getCause() == null ? error : error.getCause())) {
LOG.info("The BulkRequest of {} operation(s) has failed due to: {}:{} - retried (cause {})", requestEntries.size(), error.getClass(), error.getMessage(), error.getCause());
requestResult.accept(requestEntries);
} else {
LOG.warn("The BulkRequest of {} operation(s) has failed due to: {}:{} - not retried (cause {})", requestEntries.size(), error.getClass(), error.getMessage(), error.getCause());
}
}

Expand Down Expand Up @@ -188,7 +187,8 @@ private void handleSuccessfulRequest(
}

private boolean isRetryable(Throwable error) {
return !ELASTICSEARCH_FATAL_EXCEPTION_CLASSIFIER.isFatal(error, getFatalExceptionCons());
boolean trueIfExceptionNotThrownElseFalse = ELASTICSEARCH_FATAL_EXCEPTION_CLASSIFIER.isFatal(error, getFatalExceptionCons());
return trueIfExceptionNotThrownElseFalse ;
}

@Override
Expand Down
Loading