[FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19

[vahmed-hamdy]

Purpose of the change

Add SinkV2 implemetation for RabbitMQ.

Verifying this change

• Added unit tests for respective new implementations
• Added IT tests (moved to follow up PR to reduce PR size).
• Manually verified against local RabbitMQ cluster

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)

• Dependencies have been added or upgraded
• Public API has been changed (Public API is any class annotated with @Public(Evolving))
• Serializers have been changed
• New feature has been introduced
  • If yes, how is this documented? Follow up with another JIRA to update docs

[boring-cyborg]

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

[vahmed-hamdy]

@MartijnVisser @zentol could you please review?

[morazow]

Thanks @vahmed-hamdy, great work!

Added some suggestions

[morazow]

Thanks @vahmed-hamdy, looks good 👍

[paulh86]

Any updates?

[vahmed-hamdy]

@paulh86 Blocked on review from the community, will reach out on dev slack channel for a reviewer

[rjbaucells]

Hello,

What is the status of this PR?

Thanks

[vahmed-hamdy]

@rjbaucells Hello, It is pending approval from @MartijnVisser

[amritesh007]

Hi, are there any plans to merge this PR. Since, the SourceFunction is deprecated in the FLINK and is being replaced with SOURCE API this PR is having the latest code to migrate the connector to use Source and Sink API.

[grahambunce]

Any further update?

From what I understand, the 1.17 version of the Flink connector does not work with 1.18, 1.19 or 1.20 so anybody wanting to connect Flink to Rabbit is stuck on 1.17.

According to the Flink docs anyway here

https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/connectors/datastream/rabbitmq/

[lvyanquan]

I see that we have release 3.0.1-1.17 & 1.16 in maven repo, This PR will bump the version to 1.19. What is our release plan for 1.18 and will we skip this version

[alenzo-arch]

Are there any plans to merge this PR? Seem like its there just one open question about 1.18 (and now 1.20 as well...). 1.19 is critical for python support as well. Python 3.11 requires flink 1.19 or greater.

[grahambunce]

Is this still waiting on @MartijnVisser ?

[pfeigl]

Too bad, this never got merged :-( Completely breaks our desire to use flink for an rabbitmq to kafka usecase

[grahambunce]

Unfortunately I consider Rabbit to Flink support now deprecated and should be taken off the flink website as “supported”.

Martijn should hand over merge permissions if he is the only person who has them. He was contributing to confluent repros late last year so I assume he is still available?

[fabrizziocht]

Why is not merged this PR?

[MartijnVisser]

It is pending approval from @MartijnVisser

This isn't correct: it's pending approval by any Apache Flink committer, not specifically me. I don't have the bandwidth nor the knowledge about RabbitMQ to perform a proper review.

[vahmed-hamdy]

@MartijnVisser yup sorry it was just an assumption from your activity on the repo I guess, would you please help nominate someone from the committers?

[sunil-git1hub]

@dannycranmer I saw your commits on this repo, by any chance if you can review the changes and merge the PR ?

any plans for rabbitmq support with Flink 2.0 ?