Skip to content

Conversation

liuml07
Copy link
Member

@liuml07 liuml07 commented Oct 9, 2025

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 9, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuml07
Copy link
Member Author

liuml07 commented Oct 9, 2025

I don't think e2e test failure is related

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x16596ae]
...
Oct 09 05:08:29 [FAIL] 'Run kubernetes session test (default input)' failed after 1 minutes and 52 seconds! Test exited with exit code 1

.map(Event::getAttributes)
.map(x -> x.get("newJobStatus")))
.containsExactly(
.containsSubsequence(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at this is. My concern is that the CREATED event might not be coming out - and this is a Flink bug. I would feel for confident if the test checks that the CREATED event is coming out and the code be arranged so that the race condition does not occur. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this test cares more about the RUNNING → FAILING → FAILED events sequence when planned failures happen, I agree it's possible to hide a real problem in the Flink non-testing code. However, I do not find an easy fix that only touches the testing code to avoid the race condition. As the JobStatusChangeEvent is only for new job status (code), the initial CREATED is not expected to be captured here.

Reporting JobStatusChange event seems pretty new. @pnowojski may provide some ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we'd like to change the Flink non-testing code, I have updated the PR to demonstrate the idea of notifying the jobStatus listeners at registration time. But I presume that's a larger code change, and just share for discussion. I'll look into the code more carefully.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants