remove old asm & AnnotationMetadataReader supporting classes; adopt SimpleMetadataReaderFactory #14922
+6
−3,706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, AnnotationMetadataReader was written for performance reasons. Since Spring 5.2, this was deprecated and finally removed in 6.x. We had copied the file from Spring to get Grails 7 working, but I'm not sure this was the right decision.
Searching the internet + using chatgpt, I noticed this document. Out of curiosity, I removed the AnnotationMetadataReader & replaced it with the upstream Spring reader. All of the tests pass.
I wanted to create this PR as a discussion point since:
@Repeatable
I'm going to leave this open for discussion in next week's weekly dev meeting.