Skip to content

Conversation

slfan1989
Copy link
Contributor

Description of PR

JIRA: YARN-11879. Fix SpotBugs issues in hadoop-yarn-common module.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 10m 14s Maven dependency ordering for branch
+1 💚 mvninstall 15m 58s trunk passed
+1 💚 compile 8m 19s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 8m 23s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 checkstyle 1m 36s trunk passed
+1 💚 mvnsite 3m 48s trunk passed
+1 💚 javadoc 3m 36s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 3m 9s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+0 🆗 spotbugs 0m 12s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 1m 7s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1100 extant spotbugs warnings.
-1 ❌ spotbugs 6m 55s /branch-spotbugs-hadoop-yarn-project-warnings.html hadoop-yarn-project in trunk has 4205 extant spotbugs warnings.
-1 ❌ spotbugs 2m 9s /branch-spotbugs-hadoop-mapreduce-project-warnings.html hadoop-mapreduce-project in trunk has 265 extant spotbugs warnings.
+1 💚 shadedclient 15m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 compile 8m 1s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 1s the patch passed
+1 💚 compile 8m 23s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 33s the patch passed
+1 💚 mvnsite 3m 36s the patch passed
+1 💚 javadoc 3m 30s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 3m 4s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+0 🆗 spotbugs 0m 13s hadoop-project has no data from spotbugs
+1 💚 spotbugs 1m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 0 new + 1098 unchanged - 2 fixed = 1098 total (was 1100)
+1 💚 spotbugs 7m 7s hadoop-yarn-project generated 0 new + 4203 unchanged - 2 fixed = 4203 total (was 4205)
+1 💚 spotbugs 2m 16s hadoop-mapreduce-project in the patch passed.
+1 💚 shadedclient 16m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 14s hadoop-project in the patch passed.
+1 💚 unit 3m 51s hadoop-yarn-common in the patch passed.
-1 ❌ unit 197m 51s /patch-unit-hadoop-yarn-project.txt hadoop-yarn-project in the patch passed.
+1 💚 unit 112m 25s hadoop-mapreduce-project in the patch passed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
454m 28s
Reason Tests
Failed junit tests hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/1/artifact/out/Dockerfile
GITHUB PR #8041
Optional Tests dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname Linux e0c99c740a91 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 33dcfd6
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/1/testReport/
Max. process+thread count 1583 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project hadoop-mapreduce-project U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/1/console
versions git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 1s Docker failed to build run-specific yetus/hadoop:tp-14047}.
Subsystem Report/Notes
GITHUB PR #8041
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/2/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 4s Docker failed to build run-specific yetus/hadoop:tp-11147}.
Subsystem Report/Notes
GITHUB PR #8041
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/3/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 7m 13s Maven dependency ordering for branch
+1 💚 mvninstall 15m 49s trunk passed
+1 💚 compile 2m 50s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 2m 50s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 mvnsite 3m 51s trunk passed
+1 💚 javadoc 4m 7s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 3m 39s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 54m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 20s the patch passed
+1 💚 compile 2m 35s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 2m 35s the patch passed
+1 💚 compile 2m 45s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 2m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 3m 40s the patch passed
+1 💚 javadoc 3m 53s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 3m 27s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 25m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 199m 2s /patch-unit-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn in the patch passed.
-1 ❌ unit 202m 16s /patch-unit-hadoop-yarn-project.txt hadoop-yarn-project in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
492m 29s
Reason Tests
Failed junit tests hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/4/artifact/out/Dockerfile
GITHUB PR #8041
Optional Tests dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux 64481dd7a502 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6cb5e6b
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/4/testReport/
Max. process+thread count 1302 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project U: hadoop-yarn-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/4/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 9m 55s Maven dependency ordering for branch
+1 💚 mvninstall 28m 28s trunk passed
+1 💚 compile 5m 25s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 5m 16s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 mvnsite 7m 14s trunk passed
+1 💚 javadoc 7m 9s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 44s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 95m 43s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 6m 15s the patch passed
+1 💚 compile 4m 59s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 4m 59s the patch passed
+1 💚 compile 5m 15s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 5m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 6m 47s the patch passed
+1 💚 javadoc 6m 52s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 31s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 46m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 249m 46s /patch-unit-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn in the patch passed.
-1 ❌ unit 252m 16s /patch-unit-hadoop-yarn-project.txt hadoop-yarn-project in the patch passed.
+1 💚 asflicense 1m 6s The patch does not generate ASF License warnings.
685m 20s
Reason Tests
Failed junit tests hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/5/artifact/out/Dockerfile
GITHUB PR #8041
Optional Tests dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux dab00c5b5789 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e1c925b
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/5/testReport/
Max. process+thread count 1375 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project U: hadoop-yarn-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/5/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 9m 24s Maven dependency ordering for branch
+1 💚 mvninstall 28m 56s trunk passed
+1 💚 compile 5m 25s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 5m 18s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 mvnsite 7m 14s trunk passed
+1 💚 javadoc 7m 10s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 40s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 95m 52s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for patch
+1 💚 mvninstall 6m 11s the patch passed
+1 💚 compile 4m 59s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 4m 59s the patch passed
+1 💚 compile 5m 17s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 5m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 6m 58s the patch passed
+1 💚 javadoc 6m 54s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 26s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 46m 54s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 249m 9s /patch-unit-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn in the patch passed.
-1 ❌ unit 254m 8s /patch-unit-hadoop-yarn-project.txt hadoop-yarn-project in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
667m 3s
Reason Tests
Failed junit tests hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
hadoop.yarn.service.TestYarnNativeServices
hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity
hadoop.yarn.server.resourcemanager.TestRMHA
hadoop.yarn.service.TestYarnNativeServices
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/6/artifact/out/Dockerfile
GITHUB PR #8041
Optional Tests dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux d0a2277fb608 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2c4a942
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/6/testReport/
Max. process+thread count 1378 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project U: hadoop-yarn-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8041/6/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants