add a Makefile to vendor/ - #2218
Merged
Merged
Conversation
Fokko
approved these changes
Jul 16, 2025
| hive-metastore: | ||
| rm -rf /tmp/hive | ||
| mkdir -p /tmp/hive/share/fb303/if/ | ||
| curl -s https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift > /tmp/hive/share/fb303/if/fb303.thrift |
Contributor
There was a problem hiding this comment.
While at it, should we pass in the Hive version explicitly, instead of using master?
Contributor
Author
There was a problem hiding this comment.
i was thinking about that too.
the fb303.thrift here is in the apache/thrift repo, which has its own versioning. Its currently on v0.22.0. See https://github.com/apache/thrift/tags
hive_metastore.thrift below is in the apache/hive repo which uses hive version. Its currently on 4.0.1. See https://github.com/apache/hive/tags
Its hard to figure out which version we should pick here for each. This might be left to the person upgrading the vendor/
Contributor
Author
|
Merging this for now. We can revisit and see how we can explicitly pass in the hive version |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Add a Makefile to `vendor/`. This helps with running commands to
regenerate `vendor/`
```
# Generate all vendor packages:
make all
# Generate individual packages:
make fb303 # FB303 Thrift client only
make hive-metastore # Hive Metastore Thrift definitions only
```
Pulled this change out of apache#2217
# Are these changes tested?
Yes, ran `make all` locally
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add a Makefile to
vendor/. This helps with running commands to regeneratevendor/Pulled this change out of #2217
Are these changes tested?
Yes, ran
make alllocallyAre there any user-facing changes?