#1820 Add Geography/Geometry type #2224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| raise ValidationError(f"Could not parse {geography} into a GeographyType") | ||
| elif isinstance(geography, dict): | ||
| return geography["crs"], geography["edge_algorithm"] |
There was a problem hiding this comment.
Can you throw a user-readable error if either of these do not exist on the dictionary?
There was a problem hiding this comment.
I have created a _raise_if_any_missing_dictionary_key function, and applied it also to DecimalType & FixedType
| else: | ||
| raise ValidationError(f"Could not parse {geometry} into a GeometryType") | ||
| elif isinstance(geometry, dict): | ||
| return geometry["crs"] |
There was a problem hiding this comment.
Can you throw a user-readable error if either of these do not exist on the dictionary?
tests/test_types.py
Outdated
|
|
||
|
|
||
| def test_repr_geometry() -> None: | ||
| assert repr(GeometryType()) == "GeometryType(crs=None)" |
There was a problem hiding this comment.
According to the spec, crs can not be None.
There was a problem hiding this comment.
In Java, they took the position to store nulls, here it was not clear wether __str__ should behaved as ser_model. Nonetheless, it has been changed for both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Iceberg V3 supports both Geography & Geometry types.
Are these changes tested?
Not enough