Basic read/write support for ORC #2236
Open
+734
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccormickt12
force-pushed
the
basicSupportORC
branch
from
208b8d2 to
2dcbaa4
Compare
mccormickt12
force-pushed
the
basicSupportORC
branch
from
2dcbaa4 to
97b73b9
Compare
|
im trying to finish up some of the remaining items so we can release 0.10, https://github.com/apache/iceberg-python/milestone/10 will take a look at this PR right after :) |
@kevinjqliu Feel free to take a look. Im not going to try to merge this PR, its more for visibility early review.I will separate into read and write PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20
Some reference to https://github.com/apache/iceberg-python/pull/790/files
Rationale for this change
Support basic reading and writing of ORC data
Are these changes tested?
Unit tests added
Are there any user-facing changes?
From what I understand there are some discrepancies between pyarrow version with respect to their support for ORC, so I need to do a a bit more
Next Steps
This PR is the most basic read/write support for ORC. There also seems to be limited support for ORC in pyarrow (im still trying to understand exactly whats missing). I want to enhance the pyarrow ORC library, so this can be properly consumed here in pyiceberg