implement stageOnly Commit #2269
Open
+216
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 11, 2025
Comment on lines
121
to
+122
| branch: str = MAIN_BRANCH, | ||
| stage_only: bool = False, |
There was a problem hiding this comment.
I think API wise, this makes more sense. In the case branch is None then we don't set the ref, if it is not None then we set the ref.
Suggested change
| branch: str = MAIN_BRANCH, | |
| stage_only: bool = False, | |
| branch: Optional[str] = MAIN_BRANCH |
@kevinjqliu WDYT?
There was a problem hiding this comment.
that make sense to me. Instead of setting stage_only=True, it would be branch=None
There was a problem hiding this comment.
Make sense, thanks for taking a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In java, snapshotProducer can create stageOnly snapshot meaning only the snapshot is created but the snapshot is not set to a ref.
This is a prerequisite to support wap.id in py-iceberg
Are these changes tested?
Yes, tests are added.
Are there any user-facing changes?
By default, it will stay with the current existing behavior.