-
Notifications
You must be signed in to change notification settings - Fork 225
Jupyter Spark monitor #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the contribution @vincentye38. Adding support for spark monitor will be a great addition to Toree kernel. |
@vincentye38 could you take a look in the build failures? |
@pan3793 any comments here? |
How to trigger the PR build again? looks like the build error is not related to my code change. |
@vincentye38, when you rebase this pr it should re-run all the tests again. |
thank you. The PR build is passed. |
16827f9
to
32e50c9
Compare
@lresende Any update? |
Hi @vincentye38, some things I noticed :
![]() |
If no other comments, I will merge this tomorrow. |
Thank you @lresende for the enhancement. They looks good to me. |
...lugin/src/main/scala/org/apache/toree/plugins/sparkmonitor/JupyterSparkMonitorListener.scala
Outdated
Show resolved
Hide resolved
...lugin/src/main/scala/org/apache/toree/plugins/sparkmonitor/JupyterSparkMonitorListener.scala
Show resolved
Hide resolved
@vincentye38 FYI, now Toree also supports Scala 2.13 Could you rebase this PR on the latest master, and make sure the patch works with both Scala 2.12 and 2.13? |
Rebased on #218 |
569899a
to
f4b9113
Compare
plugins/build.sbt
Outdated
Dependencies.clapper, | ||
Dependencies.slf4jApi | ||
Dependencies.slf4jApi, | ||
Dependencies.py4j, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding the py4j dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vincentye38 . LGTM
Implement a spark-monitor plugin to sent spark progress update to SparkMonitor frontend extension.
This plugin can be built as individual jar and enable by specifying --magic-url" args[7] = "file:///path/to/spark-monitor-plugin.jar"