Skip to content

Conversation

vincentye38
Copy link
Contributor

Implement a spark-monitor plugin to sent spark progress update to SparkMonitor frontend extension.
This plugin can be built as individual jar and enable by specifying --magic-url" args[7] = "file:///path/to/spark-monitor-plugin.jar"

@lresende
Copy link
Member

lresende commented Sep 5, 2025

Thank you for the contribution @vincentye38. Adding support for spark monitor will be a great addition to Toree kernel.

@lresende
Copy link
Member

@vincentye38 could you take a look in the build failures?

@lresende
Copy link
Member

@pan3793 any comments here?

@vincentye38
Copy link
Contributor Author

@vincentye38 could you take a look in the build failures?

How to trigger the PR build again? looks like the build error is not related to my code change.

@lresende
Copy link
Member

@vincentye38, when you rebase this pr it should re-run all the tests again.

@vincentye38
Copy link
Contributor Author

thank you. The PR build is passed.

@vincentye38
Copy link
Contributor Author

@lresende Any update?

@lresende
Copy link
Member

lresende commented Oct 6, 2025

Hi @vincentye38, some things I noticed :

  • make commands were not building the jar automatically
  • jar names were not being prefixed with toree
  • rewrote the JSON parser using playjson to avoid adding new dependencies
  • [] Magic URL is a bit strange, but I understand this is something that was already there
image

@lresende
Copy link
Member

lresende commented Oct 6, 2025

If no other comments, I will merge this tomorrow.

@vincentye38
Copy link
Contributor Author

Hi @vincentye38, some things I noticed :

  • make commands were not building the jar automatically
  • jar names were not being prefixed with toree
  • rewrote the JSON parser using playjson to avoid adding new dependencies
  • [] Magic URL is a bit strange, but I understand this is something that was already there
image

Thank you @lresende for the enhancement. They looks good to me.

@pan3793
Copy link
Member

pan3793 commented Oct 7, 2025

@vincentye38 FYI, now Toree also supports Scala 2.13

Could you rebase this PR on the latest master, and make sure the patch works with both Scala 2.12 and 2.13?

@vincentye38
Copy link
Contributor Author

Rebased on #218

Dependencies.clapper,
Dependencies.slf4jApi
Dependencies.slf4jApi,
Dependencies.py4j,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding the py4j dependency here?

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vincentye38 . LGTM

@lresende lresende merged commit 145599f into apache:master Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants