KAFKA-19394: Failure in ConsumerNetworkThread.initializeResources() can cause hangs on AsyncKafkaConsumer.close() #20792
+191
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an cause hangs on AsyncKafkaConsumer.close() WIP
github-actions
bot
added
triage
Use ConsumerUtils.maybeWrapAsKafkaException to possibly reduce an extra layer of exception handling.
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
LiamClarkeNZ
approved these changes
Nov 15, 2025
Contributor
There was a problem hiding this comment.
Nice fix!
I modified an AsyncKafkaConsumer unit test on trunk to use your invalid login module approach (and a non-mocked ApplicationEventHandler) to cause the network thread to fail and observed that the consumer hung.
I then used the same test on your branch to verify that the fix prevented this.
Only feedback is that it might be good to have a unit test at the AsyncKafkaConsumerTest level along the lines of one for KafkaConsumerTest? But this isn't blocking feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplicationEventHandlernow waits for theConsumerNetworkThreadtostart up and complete execution of
initializeResources(). If resourceinitialization fails, the
AsyncKafkaConsumerconstructor will throw anexception. This mimics the behavior of
ClassicKafkaConsumer.