Repository navigation
Conversation
`RpcClientFactory` referred to the Avro and Thrift clients by class name, although they live in other repositories, and created them reflectively before configuring them. Clients are now created by providers discovered with `ServiceLoader` and selected by name through `client.type`; an unregistered provider can still be named by its class. Providers are registered with BND's `@ServiceProvider`, which also generates the JPMS and OSGi metadata. The types only needed by client implementations move to the new `org.apache.flume.client.spi` package. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
ppkarwasz
added this pull request to stack #512
October 5, 2026 20:01
rgoers
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RpcClientFactoryreferred to the Avro and Thrift clients by class name, although they now live inlogging-flume-rpc, and created them reflectively before configuring them. Clients are now created byRpcClientProviders discovered withServiceLoaderand selected byclient.type; an unregistered provider can still be named by its class.Providers are registered with BND's
@ServiceProvider, as in Log4j, which also generates the JPMSprovides/usesclauses and the OSGi capabilities. TheServiceLoaderis queried on each call, so providers can come and go.The types only needed by client implementations (
AbstractRpcClient,SSLContextAwareAbstractRpcClient,HostInfoand the newRpcClientProvider) move toorg.apache.flume.client.spi.Stacked on #511. The transports register their providers in apache/logging-flume-rpc.
🤖 Generated with Claude Code