Narrow caught exception type in generateIndex() to fix REC_CATCH_EXCEPTION #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
requested changes
Nov 17, 2025
| */ | ||
| @Parameter | ||
| private List<String> mojoDependencies = null; | ||
| private final List<String> mojoDependencies = new ArrayList<>(); |
Member
There was a problem hiding this comment.
It can not be a final ... Maven need a possibility to set this filed during plugin configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a SpotBugs warning (REC_CATCH_EXCEPTION) in
DescriptorGeneratorMojo.generateIndex(), where a generic catch (Exception)
block was used even though the code only throws IOException.
The catch block was narrowed to IOException, improving clarity and preventing
overly broad exception handling.
After the change, the REC warning no longer appears in SpotBugs.