Replace deprecated getOrComputeIfAbsent() API calls#3944
Replace deprecated getOrComputeIfAbsent() API calls#3944BACtaki wants to merge 2 commits intoapache:mainfrom
Conversation
…iter.api.extension with computeIfAbsent().
|
Requesting a quick review @adam-christian-software @snazy @dimas-b |
dimas-b
left a comment
There was a problem hiding this comment.
As I mentioned in other conversations, this change forced downstream projects that use integration-tests to adopt JUnit 6 (previously only JUnit 5 was required).... so I advised for delaying this change.
However, I can see that there's constant interest from the community to fix these deprecations... so I guess we might as well merge this change and address any (unlikely) fallout as it comes.
I think it might be worth specifically mentioning JUnit 6 in the CHANGELOG, though (section Changes). WDYT?
You make a very good point @dimas-b . We have to make this change at some point so we might as well make it now IMO. I have added a note in the changelog to highlight the point about downstream projects using JUnit 6. Let's see how it goes- I promise to address any fallout from this change, as unlikely as that may be (: |
Wouldn't it be prudent to wait until after the 1.4.0 release, due in the next few days? |
We can wait until the 1.4.0 release, there's no rush. Any specific changes in the release you think might be relevant to this PR @adutra ? |
|
Yes, merging this after 1.4.0 is branched sounds like a good compromise to me. |
|
For reference: the |
Replace deprecated
getOrComputeIfAbsent()API calls fororg.junit.jupiter.api.extensionwithcomputeIfAbsent().Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)