-
Notifications
You must be signed in to change notification settings - Fork 408
Fix broken docker-compose link in quick start guide #3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,10 +31,8 @@ Use this guide to quickly start running Polaris. This is not intended for produc | |
| ## Running | ||
|
|
||
| Run the following command: | ||
|
|
||
| ```bash | ||
kavya-seth-vns marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| curl -s https://raw.githubusercontent.com/apache/polaris/refs/heads/main/site/content/guides/quickstart/docker-compose.yml | docker compose -f - up | ||
|
|
||
| curl -s https://raw.githubusercontent.com/apache/polaris/main/site/content/guides/quickstart/docker-compose.yml | docker compose -f - up | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both URLs point to the same file, but the new one is shorter, so +1 🙂 @MonkeyCanCode : WDYT?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, on a second review pass, I get the old URL for the YAML file when I browse to the "raw" file via GH UI. With that in mind, I believe the old URL is more reliable long-term and I'd prefer to keep it (I'll remove my approval for now). Process:
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the clarification. The quickstart command already uses the original RAW URL for the docker-compose file, so no additional change was needed. Please let me know if you’d like me to update anything else. |
||
| ``` | ||
| This command will: | ||
| 1. Create a Catalog named `quickstart_catalog` with RustFS-backed storage. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it's better to keep an empty line after this line.