Skip to content

[feat] PIP-273: Enable hostname verification by default #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[feat] PIP-273: Enable hostname verification by default #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/pulsar/ClientConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class PULSAR_PUBLIC ClientConfiguration {
* It validates the incoming x509 certificate and matches the provided hostname (CN/SAN) with the
* expected broker's hostname. It follows the server identity hostname verification in RFC 2818.
*
* The default value is false.
* The default value is true.
*
* @see [RFC 2818](https://tools.ietf.org/html/rfc2818).
*
Expand Down
2 changes: 1 addition & 1 deletion lib/ClientConfigurationImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct ClientConfigurationImpl {
bool tlsAllowInsecureConnection{false};
unsigned int statsIntervalInSeconds{600}; // 10 minutes
std::unique_ptr<LoggerFactory> loggerFactory;
bool validateHostName{false};
bool validateHostName{true};
unsigned int partitionsUpdateInterval{60}; // 1 minute
std::string listenerName;
int connectionTimeoutMs{10000}; // 10 seconds
Expand Down