Skip to content

fix: remove unnecessary copies #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

fix: remove unnecessary copies #499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd73be4
fix: remove unnecessary copies
gy-deng Aug 20, 2025
183e668
add const keyword
gy-deng Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/NegativeAcksTracker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ void NegativeAcksTracker::handleTimer(const ASIO_ERROR &ec) {
break;
}

auto ledgerMap = it->second;
const auto &ledgerMap = it->second;
for (auto ledgerIt = ledgerMap.begin(); ledgerIt != ledgerMap.end(); ++ledgerIt) {
auto entrySet = ledgerIt->second;
const auto &entrySet = ledgerIt->second;
for (auto setIt = entrySet.begin(); setIt != entrySet.end(); ++setIt) {
messagesToRedeliver.insert(
MessageIdBuilder().ledgerId(ledgerIt->first).entryId(*setIt).build());
Expand Down