PIP-254: Support configuring client version #20009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
the
type/feature
BewareMyPower
requested review from
RobertIndie,
codelipenghui,
coderzc,
congbobo184,
eolivelli and
michaeljmarshall
github-actions
bot
added
the
doc
RobertIndie
reviewed
Apr 4, 2023
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
RobertIndie
approved these changes
Apr 4, 2023
### Motivation apache#19705 ### Modifications - Add the `ClientBuilderImpl#description` method to add the description to the original client version string that is set in `CommandConnect` and `CommandAuthResponse`. - Add `testClientVersion` to cover these two cases.
BewareMyPower
force-pushed
the
bewaremypower/pip-254-client-version
branch
from
2114f3a to
9ea0d23
Compare
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Apr 10, 2023
shibd
approved these changes
Apr 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #20009 +/- ##
=============================================
+ Coverage 34.65% 72.88% +38.22%
- Complexity 12429 31673 +19244
=============================================
Files 1606 1858 +252
Lines 125026 137532 +12506
Branches 13667 15129 +1462
=============================================
+ Hits 43332 100240 +56908
+ Misses 76081 29319 -46762
- Partials 5613 7973 +2360
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#19705
Modifications
ClientBuilderImpl#descriptionmethod to add the description to the original client version string that is set inCommandConnectandCommandAuthResponse.testClientVersionto cover these two cases.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#21