Skip to content

Conversation

@thetumbled
Copy link
Member

@thetumbled thetumbled commented May 15, 2024

Motivation

If the topic name is in the format of V1, we can subscribe a topic in non-existent cluster/namespace without any exception.

Modifications

Need to add check for such case.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#51

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 15, 2024
@dao-jun dao-jun requested a review from lhotari May 15, 2024 09:28
@dao-jun dao-jun added this to the 3.4.0 milestone May 15, 2024
@dao-jun dao-jun closed this May 15, 2024
@dao-jun dao-jun reopened this May 15, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @lhotari @dao-jun @BewareMyPower @poorbarcode

return FutureUtil.failedFuture(e);
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no need try/catch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

@thomas-bousquet thomas-bousquet Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible the same issue is present when the tenant does not exist as well?

@coderzc coderzc added this to the 4.2.0 milestone Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants