Skip to content

[fix][broker] Fix duplicate increment of ADD_OP_COUNT_UPDATER in OpAddEntry #24506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3pacccccc
Copy link
Contributor

Motivation

Currently, when adding a message to a ledger, ManagedLedgerImpl.ADD_OP_COUNT_UPDATER is incremented twice:

  1. First increment occurs in createOpAddEntryNoRetainBuffer() when creating the OpAddEntry
  2. Second increment occurs in OpAddEntry.initiate()

This double increment leads to incorrect operation counting and potential metric inaccuracies.
here's the example I've tested on my local.
1752159904760

Modifications

  • Changed the second occurrence in OpAddEntry.initiate() from incrementAndGet() to get() to prevent duplicate counting
  • Added a test case testAddOpCountWithMessageAdd() to verify the correct increment behavior

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 3pacccccc#11

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 11, 2025
@3pacccccc
Copy link
Contributor Author

since I got some problems when rebase to master in #24502, so I close that PR and open a new one, please take a look again. thank you
@dao-jun @nodece @Technoboy-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants