-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker] Fix deduplication replay might never complete for exceptions #24511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BewareMyPower
merged 7 commits into
apache:master
from
BewareMyPower:bewaremypower/add-ml-replay-task
Jul 25, 2025
Merged
[fix][broker] Fix deduplication replay might never complete for exceptions #24511
BewareMyPower
merged 7 commits into
apache:master
from
BewareMyPower:bewaremypower/add-ml-replay-task
Jul 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
approved these changes
Jul 24, 2025
dao-jun
approved these changes
Jul 24, 2025
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/ManagedLedgerUtils.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/BrokerMessageDeduplicationTest.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24511 +/- ##
============================================
+ Coverage 73.57% 74.32% +0.75%
- Complexity 32624 32970 +346
============================================
Files 1877 1876 -1
Lines 139502 146270 +6768
Branches 15299 16773 +1474
============================================
+ Hits 102638 108722 +6084
- Misses 28908 28921 +13
- Partials 7956 8627 +671
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) Signed-off-by: Zixuan Liu <[email protected]>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) Signed-off-by: Zixuan Liu <[email protected]>
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) (cherry picked from commit 0444514)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) (cherry picked from commit 0c1ccb8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 29, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) (cherry picked from commit 0c1ccb8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 30, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) (cherry picked from commit 0c1ccb8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2025
…tions (apache#24511) (cherry picked from commit d95cf3f) (cherry picked from commit 0444514)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #24497
Motivation
If any exception is thrown by managed cursor's API or the callback,
MessageDeduplication#checkStatus
will never have a chance to complete, which will make thePersistentTopic
never available unless unloading the namespace or topic.Modifications
ManagedLedgerUtils
, which includes a set of future-based managed ledger APIs, which don't need explicit exception catching for callback-based APIs.ManagedLedgerReplayTask
to perform replay on a managed ledger from a given position. It can handle any unexpected exception from the managed ledger APIs or callbacks.ManagedLedgerReplayTask
inMessageDeduplication
for recovery andManagedLedgerUtils
for safe snapshot taking. These two classes can be applied in some other places for safety as well, but it's beyond the scope of this PR.Verifying this change
ManagedLedgerReplayTaskTest
to verifyManagedLedgerReplayTask
works in many cases.checkStatusFail
to verifyMessageDeduplication#checkStatus
will complete exceptionally for unexpected exception.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: BewareMyPower#49