- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.7k
 
[fix][broker] Fix exclusive producer creation when last shared producer closes #24516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            crossoverJie
  merged 6 commits into
  apache:master
from
3pacccccc:fixWaitingExclusiveProducers
  
      
      
   
  Jul 23, 2025 
      
    
                
     Merged
            
            [fix][broker] Fix exclusive producer creation when last shared producer closes #24516
                    crossoverJie
  merged 6 commits into
  apache:master
from
3pacccccc:fixWaitingExclusiveProducers
  
      
      
   
  Jul 23, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    lhotari
  
              
              approved these changes
              
                  
                    Jul 16, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @3pacccccc
              
                    poorbarcode
  
              
              approved these changes
              
                  
                    Jul 18, 2025 
                  
              
              
            
            
              
                    dao-jun
  
              
              approved these changes
              
                  
                    Jul 18, 2025 
                  
              
              
            
            
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@             Coverage Diff              @@
##             master   #24516      +/-   ##
============================================
+ Coverage     73.57%   74.30%   +0.73%     
+ Complexity    32624    32583      -41     
============================================
  Files          1877     1874       -3     
  Lines        139502   146231    +6729     
  Branches      15299    16772    +1473     
============================================
+ Hits         102638   108662    +6024     
- Misses        28908    28935      +27     
- Partials       7956     8634     +678     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
  | 
    
    
  lhotari 
      pushed a commit
      that referenced
      this pull request
    
      Jul 23, 2025 
    
    
      
  
    
      
    
  
…er closes (#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8)
    
  lhotari 
      pushed a commit
      that referenced
      this pull request
    
      Jul 23, 2025 
    
    
      
  
    
      
    
  
…er closes (#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8)
    
  lhotari 
      pushed a commit
      that referenced
      this pull request
    
      Jul 23, 2025 
    
    
      
  
    
      
    
  
…er closes (#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8)
    
  priyanshu-ctds 
      pushed a commit
        to datastax/pulsar
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8) (cherry picked from commit 102fdb3)
    
  priyanshu-ctds 
      pushed a commit
        to datastax/pulsar
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8) (cherry picked from commit 102fdb3)
    
  priyanshu-ctds 
      pushed a commit
        to datastax/pulsar
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8) (cherry picked from commit efc9fa5)
    
  srinath-ctds 
      pushed a commit
        to datastax/pulsar
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8) (cherry picked from commit 102fdb3)
    
  srinath-ctds 
      pushed a commit
        to datastax/pulsar
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8) (cherry picked from commit efc9fa5)
    
  nodece 
      pushed a commit
        to ascentstream/pulsar
      that referenced
      this pull request
    
      Jul 28, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8)
    
  nodece 
      pushed a commit
        to ascentstream/pulsar
      that referenced
      this pull request
    
      Jul 28, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]> (cherry picked from commit efe9dc8)
    
  KannarFr 
      pushed a commit
        to CleverCloud/pulsar
      that referenced
      this pull request
    
      Sep 22, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]>
    
  walkinggo 
      pushed a commit
        to walkinggo/pulsar
      that referenced
      this pull request
    
      Oct 8, 2025 
    
    
      
  
    
      
    
  
…er closes (apache#24516) Co-authored-by: crossoverJie <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    cherry-picked/branch-3.0
  
    cherry-picked/branch-3.3
  
    cherry-picked/branch-4.0
  
    doc-not-needed
  Your PR changes do not impact docs 
  
    ready-to-test
  
    release/3.0.13
  
    release/3.3.8
  
    release/4.0.6
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Motivation
When a producer in
WaitForExclusivemode is created while shared producers exist on a topic, it fails to become active even after all shared producers are closed. This occurs because the broker doesn't properly check for waiting exclusive producers when the last shared producer is removed.Steps to reproduce:
Modifications
handleProducerRemoved()to also check for waiting exclusive producers when the last producer is removedVerifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#13