Skip to content

[Improve][Core] Warn that the base64 config shade does not encrypt anything #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SEZ9 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Improve][Core] Warn that the base64 config shade does not encrypt anything #12073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ private static Config processConfig(
"Miss <Sink> config! Please check the config file.");
try {
ConfigShade configShade = CONFIG_SHADES.getOrDefault(identifier, DEFAULT_SHADE);
if (Base64ConfigShade.IDENTIFIER.equals(identifier)) {
log.warn(
"Config shade '{}' encodes sensitive options, it does not encrypt them:"
+ " anyone who reads the config can decode the values.",
Base64ConfigShade.IDENTIFIER);
}
// call open method before the encrypt/decrypt
configShade.open(props);

Expand Down
Loading