[Improve][Zeta] Set the default slot-num value to twice the number of CPU cores - #9601
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request changes the default value for the slot-num configuration parameter from a fixed value of 2 to twice the number of CPU cores, making the default configuration more appropriate for different hardware environments.
- Updates the default
slot-numvalue to be calculated dynamically based on CPU cores - Adds comprehensive test coverage for the new default behavior
- Updates documentation to reflect the new default value calculation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ServerConfigOptions.java | Changes default slot-num value from 2 to CPU cores * 2 |
| YamlSeaTunnelConfigParserTest.java | Adds test to verify new default slot calculation behavior |
| customize-seatunnel.yaml | New test configuration file for slot service testing |
| customize-client.yaml | Fixes typo in cluster name from "custmoize" to "customize" |
| YamlSeaTunnelConfigLocator.java | Changes class visibility from final to non-final for testing |
| Documentation files | Updates English and Chinese docs to explain new default behavior |
Comments suppressed due to low confidence (1)
seatunnel-engine/seatunnel-engine-common/src/test/java/org/apache/seatunnel/engine/common/config/YamlSeaTunnelConfigParserTest.java:123
- The error message should be more descriptive and professional. Consider using a more specific message like "Failed to locate customize-seatunnel.yaml configuration file in working directory or classpath".
throw new RuntimeException("can't find yaml in resources");
|
|
||
| import java.io.IOException; | ||
|
|
||
| import static com.hazelcast.internal.config.DeclarativeConfigUtil.YAML_ACCEPTED_SUFFIXES; |
There was a problem hiding this comment.
[nitpick] The static import is added at the top but used only in the new test method. Consider moving this import closer to where it's used or ensure it follows the project's import organization standards.
corgy-w
approved these changes
Jul 30, 2025
liunaijie
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Set the default
slot-numvalue to twice the number of CPU cores, make default values more useful.Does this PR introduce any user-facing change?
Yes, but it is more useful than the default of 2 and does not affect existing jobs.
How was this patch tested?
add new test
Check list
New License Guide