Skip to content

[SPARK-53016][INFRA] Replace actions-rs/toolchain with dtolnay/rust-toolchain #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jul 30, 2025

What changes were proposed in this pull request?

This PR proposes to replace actions-rs/toolchain with dtolnay/rust-toolchain.
Currently actions-rs doesn't work in spark-connect-rust repository.
https://github.com/apache/spark-connect-rust/actions/runs/16609256565

actions-rs/toolchain@v1 is not allowed to be used in apache/spark-connect-rust. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: 1Password/load-secrets-action@581a835fb51b8e7ec56b71cf2ffddd7e68bb25e0, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, DavidAnson/markdownlint-cli2-action@992badcdf24e3b8eb7e87ff9287fe931bcb00c6e, DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8, DavidAnson/markdownlint-cli2-action@v16, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8, JamesIves/github-pages-deploy-action@881db5376404c5c8d621010bcbec0310b58d5e29, JamesIves/[email protected], JustinBeckwith/linkinator-action@3d5ba091319fa7b0ac14703761eebb7d100e6f6d, JustinBeckwith/[email protected], Kesin11/actions-timeline@427ee2cf860166e404d...

Also, actions-rs/toolchain is public archived.
https://github.com/actions-rs/toolchain

Why are the changes needed?

Recovering CI on GA.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I confirmed this change works on my repository.
https://github.com/sarutak/spark-connect-rust/actions/runs/16614429755

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@xuanyuanking xuanyuanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @sjrusso8 to aware this build change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants