[SPARK-52860][SQL][Test] Support V2 write schema evolution in InMemoryTable #51506
+89
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
changed the title
szehon-ho
changed the title
szehon-ho
changed the title
|
@cloud-fan @dongjoon-hyun @huaxingao can one of you take a look? Thanks |
There was a problem hiding this comment.
Thank you, @szehon-ho . Could you file a JIRA issue for traceability?
|
|
||
| // this does not override the old field with the new field with same name for now | ||
| val nameToFieldMap = oldFields.map (f => f.name -> f).toMap | ||
| val remainingNewFields = newFields.filterNot (f => nameToFieldMap.contains (f.name) ) |
There was a problem hiding this comment.
According to the code, do we assume case-sensitive column names always?
There was a problem hiding this comment.
Yea its up to the DSV2 implementation, for example Iceberg uses a config [1], which actually is the spark config spark.sql.caseSensitive [2]. ref:
- https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java#L199
- https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java#L456
I was just making a simple example for InMemoryTable, should I can make it more complex and take this property into account?
There was a problem hiding this comment.
OK i added this support as well in InMemoryTable, thanks!
szehon-ho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add test for DSV2 Write schema evolution for InMemoryTable, by making it support TableCapability.ACCEPT_ANY_SCHEMA.
Why are the changes needed?
There is a test on the analysis phase in V2WriteAnalysisSuite to make sure it skips the output resolution if this flag is enabled. But it is not end-to-end test for this feature (schema evolution on V2Write). For authors of DSV2 connector, its better to have an end to end test using the demo InMemoryTable to show to how to use this feature.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran the new test
Was this patch authored or co-authored using generative AI tooling?
No