[SPARK-54551][CONNECT][TESTS] Fix random hangs in SparkConnectJdbcDataTypeSuite #53261
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dongjoon-hyun
changed the title
...connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 29, 2025
...connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Nov 29, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM for this test change. Thank you, @vinodkc , @cloud-fan , @pan3793 .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 29, 2025
…aTypeSuite ### What changes were proposed in this pull request? Added explicit stdout/stderr redirection to Redirect.DISCARD for the child Spark Connect server process in non-debug mode in SparkConnectServerUtils. ### Why are the changes needed? SparkConnectJdbcDataTypeSuite randomly hangs because the child server process blocks on write() calls when stdout/stderr pipe buffers fill up. Without consuming the output, the buffers reach capacity and cause the process to block indefinitely. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested verified `SparkConnectJdbcDataTypeSuite` no longer randomly hangs and all tests pass consistently. ### Was this patch authored or co-authored using generative AI tooling? No Closes #53261 from vinodkc/br_handle_std_pipe. Authored-by: vinodkc <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 99270f0) Signed-off-by: Dongjoon Hyun <[email protected]>
cloud-fan
reviewed
Dec 1, 2025
...connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added explicit stdout/stderr redirection to Redirect.DISCARD for the child Spark Connect server process in non-debug mode in SparkConnectServerUtils.
Why are the changes needed?
SparkConnectJdbcDataTypeSuite randomly hangs because the child server process blocks on write() calls when stdout/stderr pipe buffers fill up. Without consuming the output, the buffers reach capacity and cause the process to block indefinitely.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested verified
SparkConnectJdbcDataTypeSuiteno longer randomly hangs and all tests pass consistently.Was this patch authored or co-authored using generative AI tooling?
No