[SPARK-54566][SQL] Enhance SparkSql FileSourceScanExec for easy integration #53281
+108
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchengchenghh
force-pushed
the
refactor
branch
from
55183ec to
85b6df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this issue apache/incubator-gluten#11216 described in Gluten, this file https://github.com/apache/incubator-gluten/blob/main/shims/spark40/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala is mostly a copy from FileSourceScanExec.
Because the source class provides inputRDD but the columnar engine only needs the finalPartitions.
What changes were proposed in this pull request?
Extract filePartitions from FileSourceScanExec inputRDDs to FileSourceScanLike filePartitions
Why are the changes needed?
The columnar engine needs the file partition information
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests can cover.
Was this patch authored or co-authored using generative AI tooling?
No