Revert "[SPARK-54310][SQL] Add numSourceRows metric for MergeIntoExec"
#53293
+227
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reverting the existing implementation to handle for cases of sourceSide child nodes without
numOutputRows, and will re-target the implementation to later Spark release.Why are the changes needed?
The current implementation may grab the incorrect
numOutputRowsmetric if there is an intermediary node (such as custom Spark operator) which does not support the metric.This is because we target the first sourceSide child node with
numOutputRows. If a SparkExtension node does not contain this metric but transforms the source table, then we could progress all the way to the source table and grab the incorrect metric.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing CI, as this is a revert
Was this patch authored or co-authored using generative AI tooling?
No