chore(docker): use editable mode in docker images - #34146
Merged
Merged
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Member
Author
|
@dpgaspar what do you think of this one!? |
eschutho
approved these changes
Jul 22, 2025
eschutho
left a comment
Member
There was a problem hiding this comment.
Looks fine for non-production use.
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
dankor
pushed a commit
to dankor/superset
that referenced
this pull request
Aug 18, 2025
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to address the issue raise here: #34120 (comment)
From my analysis, it should address the issue (package installed twice in docker) by using a symlink.
The downsides are pretty minimal, with a micro os-level penalty on resolving symlinks (super minimal from my understanding), and some considerations around image size, where in editable mode we can't/couldn't strip .py files if we wanted.
This seems like a positive step.
Other alternatives would probably require 2 extra layers (an extra build layer for both dev and lean), and it's hard to keep the docker logic DRY and readable in that context. Personally I'm not willing to take this on now... With that approach, we wouldn't have
/app/supersetand would only have superset/ in.venv, could compile and strip.pyto only keep.pycif we wanted there.Doing some research, it seems python is still very much lacking around managing lean packages/bundles of bytecode only, where wheels and packages in general tend to be raw .py, and it's tricky to only pacakge .pyc if/when desired.
Some benefits from the
-e(editable mode)./app/supersetin docker: