fix(Table chart): fix percentage metric column #34175
Open
+279
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Incorrect percentage metric filtering logic ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigItem.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
592
to
606
| if ( | ||
| explore.form_data.metrics?.some( | ||
| metric => getMetricLabel(metric) === colname, | ||
| ) || | ||
| colname && | ||
| !colname.startsWith('%') && | ||
| colnames.includes(`%${colname}`) && | ||
| explore.form_data.percent_metrics?.some( | ||
| (metric: QueryFormMetric) => | ||
| getMetricLabel(metric) === colname, | ||
| ) && | ||
| !explore.form_data.metrics?.some( | ||
| (metric: QueryFormMetric) => | ||
| getMetricLabel(metric) === colname, | ||
| ) | ||
| ) { | ||
| return; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
LevisNgigi
force-pushed
the
fix-percentage-metric-bug
branch
from
110463b to
19cde09
Compare
superset-frontend/packages/superset-ui-core/src/chart/models/ChartProps.ts
Outdated
Show resolved
Hide resolved
...-frontend/packages/superset-ui-core/src/chart/registries/ChartBuildQueryRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
...t-frontend/packages/superset-ui-core/src/chart/registries/ChartComponentRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
...rontend/packages/superset-ui-core/src/chart/registries/ChartControlPanelRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
...et-frontend/packages/superset-ui-core/src/chart/registries/ChartMetadataRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/query/getXAxis.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/utils/isJsonString.ts
Outdated
Show resolved
Hide resolved
LevisNgigi
force-pushed
the
fix-percentage-metric-bug
branch
from
1ab405f to
19cde09
Compare
superset-frontend/packages/superset-ui-chart-controls/src/utils/metricColumnFilter.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-chart-controls/src/utils/metricColumnFilter.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Related to PR. Fixes a bug in the Table chart where percentage metrics (e.g., %count) did not appear or behave correctly in the Customize Columns section.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
2025-07-17.20-41-55.mp4
AFTER
after.mp4
TESTING INSTRUCTIONS
You should now:
a)See Main %count listed and the child columns.
b)Be able to rename it (e.g., "Conversion Rate")
c)Hide child columns, and verify they disappear from the table
d)Also verify that comparison columns for %count are generated properly when time comparison is enabled and regular metrics like COUNT(*) are preserved and configurable
ADDITIONAL INFORMATION