feat: Add configurable query identifiers for Mixed Timeseries charts #34200
+154
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inline Visibility Function ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| description: t('Adds Query A and Query B identifiers to metrics to help differentiate series'), | ||
| default: false, | ||
| renderTrigger: true, | ||
| visibility: ({ controls }) => Boolean(controls?.rich_tooltip?.value), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sadpandajoe
force-pushed
the
query-identifier-control
branch
from
a289b43 to
12dd4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a new configuration option "Show query identifiers" to Mixed Timeseries charts, allowing users to control whether "(Query A)" and "(Query B)" identifiers appear in tooltips and legends.
Following the implementation of query identifiers in #33519, some customers provided feedback that they prefer not to see these identifiers in their charts. This PR makes the feature configurable.
Changes
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION