fix: Enable DuckDB examples loading in showtime ephemeral environments #35294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronments This adds the missing SUPERSET__SQLALCHEMY_EXAMPLES_URI environment variable to the ECS task definition used by showtime ephemeral environments. Without this configuration, showtime environments were unable to load examples because the container didn't know where to find the DuckDB examples file that was downloaded during Docker build (via LOAD_EXAMPLES_DUCKDB=true). The URI matches what's used in docker-compose.yml and docker-compose-light.yml, with read-only access mode for safety in ephemeral environments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This fixes an issue where the LOAD_EXAMPLES_DUCKDB build argument was being ignored during multi-stage Docker builds, causing showtime ephemeral environments to fail loading examples. Problem: The ARG was declared inside the python-common stage, making it unavailable when passed via --build-arg to the showtime target. Solution: Move the ARG declaration to global scope (before any FROM) and re-declare it in the python-common stage where it's used. This follows Docker's multi-stage build ARG scope rules. This fix ensures that when showtime builds with: docker buildx build --build-arg LOAD_EXAMPLES_DUCKDB=true --target showtime The DuckDB examples file will actually be downloaded during the build. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
eschutho
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
geido,
kgabryje,
mistercrunch,
nytai,
rusackas and
villebro
as code owners
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
github-actions
bot
added
the
github_actions
…ime environments" This reverts commit 55e3da4.
github-actions
bot
removed
the
github_actions
eschutho
added
the
🎪 ⚡ showtime-trigger-start
github-actions
bot
added
🎪 482b710 🚦 building
github-actions
bot
added
🎪 482b710 🚦 deploying
github-actions
bot
removed
🎪 71e4fcf 🤡 eschutho
|
🎪 Showtime deployed environment on GHA for ecfedd4 • Environment: http://52.38.229.242:8080 (admin/admin) |
github-actions
bot
added
🎪 8ae41ba 🚦 failed
eschutho
added
the
🎪 🛑 showtime-trigger-stop
github-actions
bot
removed
🎪 🛑 showtime-trigger-stop
rusackas
removed
the
review:checkpoint
|
Examples are showing up in the ephemeral now. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical issues preventing DuckDB examples from loading in showtime ephemeral environments:
LOAD_EXAMPLES_DUCKDBbuild argument was being ignoredunhashable type: '_duckdb.typing.DuckDBPyType'errorsProblems Fixed
1. Docker Build Argument Scope
Issue: The
LOAD_EXAMPLES_DUCKDBARG was declared inside thepython-commonstage, making it unavailable when passed via--build-argto theshowtimetarget in multi-stage builds.Fix: Move ARG declaration to global scope and re-declare in the stage where it's used.
2. DuckDB Version Compatibility
Issue: Current DuckDB version
1.3.2has type system changes incompatible with duckdb-engine, causing connection failures.Fix: Constrain DuckDB core to
>=0.10.2,<0.11while keeping duckdb-engine at current>=0.17.0. Testing confirmed the newer driver works fine with DuckDB 0.10.x.Version Constraints
Rationale:
Testing
✅ Local testing confirms both fixes work:
Before/After
Before:
LOAD_EXAMPLES_DUCKDB=true→ No examples file downloadedAfter:
Impact
This enables showtime ephemeral environments to successfully load and display examples, making them much more useful for testing and demonstration purposes.
🤖 Generated with Claude Code