Skip to content

Conversation

@rebenitez1802
Copy link
Contributor

SUMMARY

Fixes the unsaved changes modal not closing when user clicks "Discard" during chart editing navigation.

Root cause: The handleConfirmNavigation function was missing setShowModal(false) call, causing the modal to remain open after navigation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Open any chart
  2. change something like time grain or metric
  3. click the back button in the browser
  4. click on discard button

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@korbit-ai
Copy link

korbit-ai bot commented Sep 26, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@rebenitez1802 rebenitez1802 changed the title fix(explore): close unsaved changes modal when discarding changes fix(explore): close unsaved changes modal when discarding changes Sep 26, 2025
@rebenitez1802 rebenitez1802 marked this pull request as ready for review September 26, 2025 13:12
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/hooks/useUnsavedChangesPrompt/index.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Sep 26, 2025
@rusackas
Copy link
Member

@geido care to re-review, now that tests are in?

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@geido geido merged commit d8688cf into apache:master Oct 1, 2025
69 checks passed
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Oct 1, 2025
sadpandajoe pushed a commit that referenced this pull request Oct 1, 2025
@SBIN2010
Copy link
Contributor

SBIN2010 commented Oct 1, 2025

Снимок экрана от 2025-10-02 00-44-13

The checks fail because of the test.
testing guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend size/M v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants