- 
                Notifications
    
You must be signed in to change notification settings  - Fork 16.1k
 
fix(explore): close unsaved changes modal when discarding changes #35307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): close unsaved changes modal when discarding changes #35307
Conversation
| 
           Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment  
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed | 
|---|---|
| superset-frontend/src/hooks/useUnsavedChangesPrompt/index.ts | ✅ | 
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| 
           @geido care to re-review, now that tests are in?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test!
           
The checks fail because of the test.  | 
    

SUMMARY
Fixes the unsaved changes modal not closing when user clicks "Discard" during chart editing navigation.
Root cause: The handleConfirmNavigation function was missing setShowModal(false) call, causing the modal to remain open after navigation.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION